Catch the error when loading library failed #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
added a commit
that referenced
this pull request
Mar 10, 2025
Currently, `interfaces.d.ts`, a declaration file for ROS2 messages, will be generated when running `npm install`, which needs to require the `.js` files of messages and the `ref-napi` C++ addon gets loaded. There could be a corner case that the `ref-napi` C++ addon is cross-compiled for arm arch, so loading `binding.node` dynamically failed on x86 platform, see details #1066. This patch catches the error when loading the library failed, and if it happens, we will use a prebuild `interfaces.d.ts` instead. Meanwhiles, this patch moves out generating `interfaces.d.ts` file out of `generate-messages` command because it already executed. Fix: #1066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
interfaces.d.ts, a declaration file for ROS2 messages, will be generated when runningnpm install, which needs to require the.jsfiles of messages and theref-napiC++ addon gets loaded.There could be a corner case that the
ref-napiC++ addon is cross-compiled for arm arch, so loadingbinding.nodedynamically failed on x86 platform, see details #1066.This patch catches the error when loading the library failed, and if it happens, we will use a prebuild
interfaces.d.tsinstead. Meanwhiles, this patch moves out generatinginterfaces.d.tsfile out ofgenerate-messagescommand because it already executed.Fix: #1066